LatestWindowsTfm added to Directory.Build.props#5277
Merged
Conversation
Add LatestWindowsTfm to `Directory.Build.props` and include it in the `TargetFrameworks` of `Sentry.Maui.csproj`. This update ensures that the project targets the latest Windows TFM which fixes getsentry#4578
Collaborator
|
@nor0x apologies for the delay (I've been on holiday the last 3 weeks) and thank you very much for the PR! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5277 +/- ##
==========================================
- Coverage 74.09% 74.05% -0.05%
==========================================
Files 508 508
Lines 18320 18320
Branches 3584 3584
==========================================
- Hits 13575 13566 -9
- Misses 3872 3882 +10
+ Partials 873 872 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jamescrosswell
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
LatestWindowsTfmtoDirectory.Build.propsand include it in theTargetFrameworksofSentry.Maui.csproj. This update ensures that the project targets the latest Windows TFM. This fixes #5037 for meRoot cause
Sentry.Maui's TFM list (Directory.Build.props + Sentry.Maui.csproj) ships these Windows-relevant assets before the PR:
net10.0— generic, no WinUI lifecycle/event bindersnet9.0-windows10.0.19041.0— the only asset that contains the Windows breadcrumb bindersA .NET 10 MAUI app targets
net10.0-windows10.0.19041.0. NuGet's nearest-framework algorithm prioritizes the highest .NET major version first, so it picks the genericnet10.0asset over the platform-specificnet9.0-windowsone. The app therefore binds against the Windows-blind generic assembly → no automatic breadcrumbs on Windows.